sunm2n commented on PR #23344: URL: https://github.com/apache/kafka/pull/23344#issuecomment-5533903760
Thanks for the review! I've pushed a second commit that cleans up the tools test module `ConnectInternalTopicsTest` and `DumpLogSegmentsTest` are updated — `Collections.singleton()`, `singletonList()` and `emptyMap()` are replaced with `Set.of()`, `List.of()` and `Map.of()`, and the now-unused `java.util.Collections` imports are removed I deliberately left a few call sites alone: - `ConfigCommandTest#511` and `ShareGroupCommandTest#265` use `Collections.singletonMap()` with a null value, and `Map.of()` rejects nulls - `Collections.nCopies()`, `disjoint()` and `emptyIterator()` have no `List.of()`-style equivalent Let me know if you'd prefer a different scope -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
