Russole opened a new pull request, #23378:
URL: https://github.com/apache/kafka/pull/23378

   ### Summary
   
   This PR cleans up `ListConsumerGroupTest` and avoids starting a cluster for 
tests that only validate argument parsing or string parsing logic.
   
   The main changes are:
   
   - Remove the class-level `@ClusterTestDefaults` and apply the cluster 
configuration only to tests that require a real cluster.
   - Convert `testListWithUnrecognizedNewConsumerOption` to a plain `@Test`, 
since it only verifies that `--new-consumer` is rejected by 
`ConsumerGroupCommandOptions.fromArgs`.
   - Pass `ClusterInstance` explicitly to cluster-backed helper methods instead 
of keeping it as test class state.
   - Merge the package-private `ListConsumerGroupUnitTest` into 
`ListConsumerGroupTest`, so the file contains a single test class.
   - Remove the old `set(...)` helper and use typed `Set` / `HashSet` directly 
while keeping the surrounding test style consistent with nearby Kafka tests.
   
   ### Testing
   
   Passed:
   
   ```bash
   ./gradlew :tools:test --tests 
org.apache.kafka.tools.consumer.group.ListConsumerGroupTest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to