AndrewJSchofield commented on code in PR #23371:
URL: https://github.com/apache/kafka/pull/23371#discussion_r3951280396
##########
server/src/main/java/org/apache/kafka/server/metrics/ClientMetricsConfigs.java:
##########
@@ -195,7 +195,7 @@ public static Map<String, Pattern>
parseMatchingPatterns(List<String> patterns)
Map<String, Pattern> patternsMap = new HashMap<>();
patterns.forEach(pattern -> {
- String[] nameValuePair = pattern.split("=");
+ String[] nameValuePair = pattern.split("=", 2);
Review Comment:
Please put a comment above the modified line explaining that the value can
contain instances of =. Otherwise, people are going to be looking for the
javadoc figuring out why it was changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
