chia7712 commented on code in PR #23386:
URL: https://github.com/apache/kafka/pull/23386#discussion_r3963821733
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/GlobalKTableIntegrationTest.java:
##########
@@ -203,7 +202,7 @@ public void shouldKStreamGlobalKTableLeftJoin(final boolean
withHeaders) throws
final ReadOnlyKeyValueStore<Long, ValueAndTimestamp<String>>
replicatedStoreWithTimestamp = IntegrationTestUtils
.getStore(globalStore, kafkaStreams,
QueryableStoreTypes.timestampedKeyValueStore());
assertNotNull(replicatedStoreWithTimestamp);
- assertThat(replicatedStoreWithTimestamp.get(5L),
equalTo(ValueAndTimestamp.make("J", firstTimestamp + 4L)));
+ assertEquals(ValueAndTimestamp.make("J", firstTimestamp + 4L),
replicatedStoreWithTimestamp.get(5L));
Review Comment:
It appears `shouldKStreamGlobalKTableLeftJoin` and
`shouldKStreamGlobalKTableJoin` are almost are almost identical. Maybe we could
open a follow-up to refactor them :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
