m1a2st commented on code in PR #23387:
URL: https://github.com/apache/kafka/pull/23387#discussion_r3965321119
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractSessionBytesStoreTest.java:
##########
@@ -728,17 +724,17 @@ public void shouldFetchAndIterateOverExactBinaryKeys() {
final List<String> expectedKey1 = asList("1", "4", "7");
try (KeyValueIterator<Windowed<Bytes>, String> iterator =
sessionStore.findSessions(key1, 0L, Long.MAX_VALUE)) {
- assertThat(valuesToSet(iterator), equalTo(new
HashSet<>(expectedKey1)));
+ assertEquals(new HashSet<>(expectedKey1), valuesToSet(iterator));
Review Comment:
We can use `Set` directly instead of creating a `List` first and then
converting it to a `Set`.
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractSessionBytesStoreTest.java:
##########
@@ -728,17 +724,17 @@ public void shouldFetchAndIterateOverExactBinaryKeys() {
final List<String> expectedKey1 = asList("1", "4", "7");
try (KeyValueIterator<Windowed<Bytes>, String> iterator =
sessionStore.findSessions(key1, 0L, Long.MAX_VALUE)) {
- assertThat(valuesToSet(iterator), equalTo(new
HashSet<>(expectedKey1)));
+ assertEquals(new HashSet<>(expectedKey1), valuesToSet(iterator));
}
final List<String> expectedKey2 = asList("2", "5", "8");
try (KeyValueIterator<Windowed<Bytes>, String> iterator =
sessionStore.findSessions(key2, 0L, Long.MAX_VALUE)) {
- assertThat(valuesToSet(iterator), equalTo(new
HashSet<>(expectedKey2)));
+ assertEquals(new HashSet<>(expectedKey2), valuesToSet(iterator));
Review Comment:
ditto
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractSessionBytesStoreTest.java:
##########
@@ -728,17 +724,17 @@ public void shouldFetchAndIterateOverExactBinaryKeys() {
final List<String> expectedKey1 = asList("1", "4", "7");
try (KeyValueIterator<Windowed<Bytes>, String> iterator =
sessionStore.findSessions(key1, 0L, Long.MAX_VALUE)) {
- assertThat(valuesToSet(iterator), equalTo(new
HashSet<>(expectedKey1)));
+ assertEquals(new HashSet<>(expectedKey1), valuesToSet(iterator));
}
final List<String> expectedKey2 = asList("2", "5", "8");
try (KeyValueIterator<Windowed<Bytes>, String> iterator =
sessionStore.findSessions(key2, 0L, Long.MAX_VALUE)) {
- assertThat(valuesToSet(iterator), equalTo(new
HashSet<>(expectedKey2)));
+ assertEquals(new HashSet<>(expectedKey2), valuesToSet(iterator));
}
final List<String> expectedKey3 = asList("3", "6", "9");
try (KeyValueIterator<Windowed<Bytes>, String> iterator =
sessionStore.findSessions(key3, 0L, Long.MAX_VALUE)) {
- assertThat(valuesToSet(iterator), equalTo(new
HashSet<>(expectedKey3)));
+ assertEquals(new HashSet<>(expectedKey3), valuesToSet(iterator));
Review Comment:
ditto
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractSessionBytesStoreTest.java:
##########
@@ -768,17 +764,17 @@ public void
shouldBackwardFetchAndIterateOverExactBinaryKeys() {
final List<String> expectedKey1 = asList("7", "4", "1");
try (KeyValueIterator<Windowed<Bytes>, String> iterator =
sessionStore.backwardFindSessions(key1, 0L, Long.MAX_VALUE)) {
- assertThat(valuesToSet(iterator), equalTo(new
HashSet<>(expectedKey1)));
+ assertEquals(new HashSet<>(expectedKey1), valuesToSet(iterator));
}
final List<String> expectedKey2 = asList("8", "5", "2");
try (KeyValueIterator<Windowed<Bytes>, String> iterator =
sessionStore.backwardFindSessions(key2, 0L, Long.MAX_VALUE)) {
- assertThat(valuesToSet(iterator), equalTo(new
HashSet<>(expectedKey2)));
+ assertEquals(new HashSet<>(expectedKey2), valuesToSet(iterator));
}
final List<String> expectedKey3 = asList("9", "6", "3");
try (KeyValueIterator<Windowed<Bytes>, String> iterator =
sessionStore.backwardFindSessions(key3, 0L, Long.MAX_VALUE)) {
- assertThat(valuesToSet(iterator), equalTo(new
HashSet<>(expectedKey3)));
+ assertEquals(new HashSet<>(expectedKey3), valuesToSet(iterator));
Review Comment:
ditto
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractSessionBytesStoreTest.java:
##########
@@ -768,17 +764,17 @@ public void
shouldBackwardFetchAndIterateOverExactBinaryKeys() {
final List<String> expectedKey1 = asList("7", "4", "1");
try (KeyValueIterator<Windowed<Bytes>, String> iterator =
sessionStore.backwardFindSessions(key1, 0L, Long.MAX_VALUE)) {
- assertThat(valuesToSet(iterator), equalTo(new
HashSet<>(expectedKey1)));
+ assertEquals(new HashSet<>(expectedKey1), valuesToSet(iterator));
Review Comment:
ditto
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractSessionBytesStoreTest.java:
##########
@@ -768,17 +764,17 @@ public void
shouldBackwardFetchAndIterateOverExactBinaryKeys() {
final List<String> expectedKey1 = asList("7", "4", "1");
try (KeyValueIterator<Windowed<Bytes>, String> iterator =
sessionStore.backwardFindSessions(key1, 0L, Long.MAX_VALUE)) {
- assertThat(valuesToSet(iterator), equalTo(new
HashSet<>(expectedKey1)));
+ assertEquals(new HashSet<>(expectedKey1), valuesToSet(iterator));
}
final List<String> expectedKey2 = asList("8", "5", "2");
try (KeyValueIterator<Windowed<Bytes>, String> iterator =
sessionStore.backwardFindSessions(key2, 0L, Long.MAX_VALUE)) {
- assertThat(valuesToSet(iterator), equalTo(new
HashSet<>(expectedKey2)));
+ assertEquals(new HashSet<>(expectedKey2), valuesToSet(iterator));
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
