ramu11 commented on code in PR #23298:
URL: https://github.com/apache/kafka/pull/23298#discussion_r3975196306
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java:
##########
@@ -533,6 +535,31 @@ void restore(final StateStoreMetadata storeMetadata, final
List<ConsumerRecord<b
}
}
+ /**
+ * Records that restoration has conclusively reached {@code
nextOffsetToFetch} (Kafka next-offset-to-fetch
+ * semantics: log-end offset / restore boundary), converting to
last-applied as
+ * {@code nextOffsetToFetch - 1}. Used when a catch-up boundary is
confirmed with no further records
+ * to apply (KAFKA-14302). Does not change {@link #changelogOffsets()}
mapping of {@code null -> 0}.
+ */
Review Comment:
Thanks for catching this. Updated the Javadoc to remove the log-end offset
gloss and clarify that `nextOffsetToFetch` represents the exclusive end/limit
offset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
