kuoche1712003 opened a new pull request, #23417:
URL: https://github.com/apache/kafka/pull/23417
The two shouldThrowTimeoutException...HasTopicDescriptionTimeout tests
wrapped the call under test in try/catch without fail(), so they passed
whether or not an exception was thrown. Since KAFKA-14128 the code under
test swallows the TimeoutException from describeTopics and never throws,
so the catch block and its assertion have never executed.
Rename both tests to shouldNotThrowExceptionIf... and replace the
try/catch with assertDoesNotThrow so they fail if the behavior regresses
to throwing. Also collapse the duplicated identical call in the
getNumPartitions test, which was introduced by a rebase conflict
resolution in PR #13161.
Testing: test-only change. Ran InternalTopicManagerTest locally, all
passing.
No production code is affected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
