chia7712 commented on code in PR #22982:
URL: https://github.com/apache/kafka/pull/22982#discussion_r3992202754
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -882,6 +890,18 @@ protected List<ConsumerGroupPartitionAssignor>
consumerGroupAssignors(
assignors.add(assignor);
+ if (!builtInAssignorClasses.contains(assignor.getClass()) &&
builtInAssignors.containsKey(assignor.name())) {
Review Comment:
This is a kind of behaviour change, right? Users who intentionally override
the built-in assignor will see a `ConfigException` instead. Of course, that is
an odd use case, so it probably doesn't need a KIP. However, adding this change
to `upgrade.md` would be a kind behaviour to users :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
