majialoong commented on code in PR #22874:
URL: https://github.com/apache/kafka/pull/22874#discussion_r4000272402
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/AddPartitionsTest.java:
##########
@@ -122,6 +125,31 @@ public void testIncrementPartitions(ClusterInstance
cluster) throws Exception {
}
}
+ @ClusterTests(value = {
+ @ClusterTest(types = {Type.KRAFT}, brokers = 3, controllers = 3,
metadataVersion = MetadataVersion.IBP_3_7_IV0),
+ @ClusterTest(types = {Type.KRAFT}, brokers = 3, controllers = 3,
metadataVersion = MetadataVersion.IBP_3_7_IV2)
+ })
+ public void testCreatePartitionsWithPartialFailure(ClusterInstance
cluster) throws Exception {
Review Comment:
The original PR doesn't explain why these metadata versions were chosen.
Since 3.7-IV2 introduced JBOD support in KRaft, I suspect the test was intended
to cover behavior before and after that change.
I'd prefer to keep it to preserve that coverage. I've also renamed it to
`testCreatePartitionsAcrossMetadataVersions` to make the version coverage
clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
