AndrewJSchofield commented on code in PR #23465:
URL: https://github.com/apache/kafka/pull/23465#discussion_r4016106867
##########
server/src/main/java/org/apache/kafka/server/metrics/MetricConfigs.java:
##########
@@ -65,7 +65,9 @@ public class MetricConfigs {
public static final String CLIENT_TELEMETRY_MAX_BYTES_CONFIG =
"telemetry.max.bytes";
public static final int CLIENT_TELEMETRY_MAX_BYTES_DEFAULT = 1024 * 1024;
public static final String CLIENT_TELEMETRY_MAX_BYTES_DOC = "The maximum
size (after compression if compression is used) of" +
- " telemetry metrics pushed from a client to the broker. The
default value is 1048576 (1 MB).";
+ " telemetry metrics pushed from a client to the broker. This value
is also used to bound the size of the" +
Review Comment:
I think this can be said more succinctly. Something like "The maximum size
of telemetry metrics pushed from a client to the broker. If the metrics are
compressed, the limit is applied to the decompressed size too. The default
value is 1048576 (1 MB).".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
