harmadasg commented on code in PR #22513:
URL: https://github.com/apache/kafka/pull/22513#discussion_r4028251749
##########
clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java:
##########
@@ -172,6 +165,15 @@ public void configure(Map<String, ?> configs) {
(Password)
configs.get(SslConfigs.SSL_TRUSTSTORE_CERTIFICATES_CONFIG));
this.sslContext = createSSLContext(keystore, truststore);
+
+ List<String> cipherSuitesList = (List<String>)
configs.get(SslConfigs.SSL_CIPHER_SUITES_CONFIG);
+ if (!cipherSuitesList.isEmpty()) {
+ Set<String> supportedCiphers = Set.of(
+ sslContext.getSupportedSSLParameters().getCipherSuites());
Review Comment:
@showuon Thanks for reviewing! I have addressed the potential null value in
[5d4c921](https://github.com/apache/kafka/pull/22513/commits/5d4c921570ab5f16b54d5ca549f5821cd9b8bafd).
I think in that case it is acceptable to fall back to the old behavior
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
