sunm2n commented on PR #23390: URL: https://github.com/apache/kafka/pull/23390#issuecomment-5708353606
@UladzislauBlok, following up on the remaining design question. I've addressed the inline feedback, added the double-cleanup fix and regression coverage, and merged trunk to resolve the conflict with #23407. I've also updated the PR description to reflect these changes. My preference is to keep the handling in `GlobalStreamThread`, alongside the existing `InvalidOffsetException` path. I'm also happy to move it into `GlobalStateManagerImpl`, while preserving the cleanup and startup-failure behavior covered by the tests. Would you prefer moving the handling into `GlobalStateManagerImpl`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
