ChoMinGi commented on code in PR #23461:
URL: https://github.com/apache/kafka/pull/23461#discussion_r4033104155
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##########
@@ -598,33 +598,25 @@ private void verifyParents(final String processorName,
final String... predecess
public final void addStateStore(final StoreBuilder<?> storeBuilder,
final String... processorNames) {
Objects.requireNonNull(storeBuilder, "storeBuilder cannot be null");
- addStateStore(StoreBuilderWrapper.wrapStoreBuilder(storeBuilder),
false, processorNames);
+ addStateStore(StoreBuilderWrapper.wrapStoreBuilder(storeBuilder),
processorNames);
}
public final void addStateStore(final StoreFactory storeFactory,
final String... processorNames) {
- addStateStore(storeFactory, false, processorNames);
- }
-
- public final void addStateStore(final StoreFactory storeFactory,
- final boolean allowOverride,
- final String... processorNames) {
Objects.requireNonNull(storeFactory, "stateStoreFactory cannot be
null");
Review Comment:
@chia7712
Thanks for catching this!
I checked similar messages in the codebase and this was the only actual
variable-name mismatch I found.
Fixed in
[cf73d353ae](https://github.com/apache/kafka/pull/23461/changes/cf73d353ae842543add7e1f2c9cb06b076c7d7bc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
