squah-confluent commented on code in PR #23220:
URL: https://github.com/apache/kafka/pull/23220#discussion_r4038916400
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorShardCompactionReplayTest.java:
##########
@@ -548,9 +548,9 @@ private void
assertCompactedVariantsLoadCleanly(CompactionReplayTestContext cont
}
/**
- * The positions in {@code log} eligible for compaction: a record
superseded by a later record
- * with the same key is always compactable. When {@code deleteTombstones}
is set, a tombstone with
- * no later record for its key is also compactable, modelling {@code
delete.retention.ms} elapsing.
+ * The positions in {@code log} eligible for compaction: any offset with a
later offset with the
+ * same kay is compactable. When {@code deleteTombstones} is set, a
tombstone with
+ * no later offset for its key is also compactable, modelling {@code
delete.retention.ms} elapsing.
*/
private static Set<Integer> compactablePositions(List<CoordinatorRecord>
log, boolean deleteTombstones) {
Review Comment:
> In Kafka record positions are called offsets. Let's use the existing
terminology.
Sorry for the misunderstanding. I was referring to the "positions" naming.
"records" is fine since that's the actual terminology Kafka uses and we're
using it correctly in the javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
