chia7712 commented on code in PR #23492:
URL: https://github.com/apache/kafka/pull/23492#discussion_r4040675753
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/StreamsUpgradeTestIntegrationTest.java:
##########
@@ -60,6 +61,7 @@ public static void closeCluster() {
@Test
public void testVersionProbingUpgrade() throws InterruptedException {
+ final CloseOptions leave =
CloseOptions.groupMembershipOperation(LEAVE_GROUP);
Review Comment:
@JiayaoS Would you mind adding a comment explaining why we don't use the
default policy here? The default close() does not leave the group, so each roll
would wait for the session timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
