alanlau28 opened a new pull request, #23511:
URL: https://github.com/apache/kafka/pull/23511

   Jira: https://issues.apache.org/jira/browse/KAFKA-20923
   
   KIP-1313: 
https://cwiki.apache.org/confluence/spaces/KAFKA/pages/406624038/KIP-1313+Client+instance+ID+in+all+request+headers
   
   Follow-up to #23317, which introduced `headerVersions` as an optional
   schema property. This PR makes it mandatory: `MessageSpec` now rejects,
   at parse time, any request/response schema with valid versions that
   omits `headerVersions`, with an actionable error message showing the
   expected shape. The generator's flexibleVersions-derived fallback for
   `requestHeaderVersion`/`responseHeaderVersion` is removed and replaced
   with an `orElseThrow` in `ApiMessageTypeGenerator` that asserts every
   RPC has a declared map, so the schema is now the single source of
   truth for header version selection. Generator test fixtures are
   backfilled with `headerVersions`, and the README is updated to state
   the new requirement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to