dejan2609 commented on PR #23424: URL: https://github.com/apache/kafka/pull/23424#issuecomment-5740875788
It seems that this PR is ready for a review. I did some testing and compared scanned files in trunk and this PR; see test procedure below: 1. execute `./gradlew rat` on this PR (Gradle RAT plugin: 0.11.0 / RAT 0.18): 2. rename folder `/build/rat` to `/build/rat-PR` 3. cd /build/rat-PR 4. extract list of scanned files into a separate file: ``` sed -n 's/\r//g; s/^[[:space:]]*\(\/.*\)/\1/p' rat-report.txt | sort > rat-report-scanned-files-PR.txt ``` 5. checkout last trunk commit in this PR: `7a09196f93` (Gradle RAT plugin: 0.8.1 / RAT 0.15): 6. execute `./gradlew rat` 7. rename folder `/build/rat` to `/build/rat-trunk` 8. extract list of scanned files into a separate file: ``` sed -n '/\// s|.*/home/dejan/kafka||p' rat-report.txt | sort > rat-report-scanned-files-TRUNK.txt ``` 9. compare two files created above: ``` dejan@home:~/kafka$ diff build/rat-PR/rat-report-scanned-files-PR.txt build/rat-trunk/rat-report-scanned-files-TRUNK.txt 3647a3648 > /gradle/resources/rat-output-to-html.xsl dejan@home:~/kafka$ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
