chia7712 commented on code in PR #23526: URL: https://github.com/apache/kafka/pull/23526#discussion_r4058526290
########## docs/getting-started/quickstart.md: ########## @@ -152,43 +167,53 @@ First, make sure to add `connect-file-4.3.0.jar` to the `plugin.path` property i Edit the `config/connect-standalone.properties` file, add or change the `plugin.path` configuration property match the following, and save the file: ```bash -$ echo "plugin.path=libs/connect-file-4.3.0.jar" >> config/connect-standalone.properties +echo "plugin.path=libs/connect-file-4.3.0.jar" >> config/connect-standalone.properties ``` Then, start by creating some seed data to test with: ```bash -$ echo -e "foo +echo -e "foo Review Comment: Why not just copy the style of Windows? ########## docs/getting-started/quickstart.md: ########## @@ -152,43 +167,53 @@ First, make sure to add `connect-file-4.3.0.jar` to the `plugin.path` property i Edit the `config/connect-standalone.properties` file, add or change the `plugin.path` configuration property match the following, and save the file: ```bash -$ echo "plugin.path=libs/connect-file-4.3.0.jar" >> config/connect-standalone.properties +echo "plugin.path=libs/connect-file-4.3.0.jar" >> config/connect-standalone.properties ``` Then, start by creating some seed data to test with: ```bash -$ echo -e "foo +echo -e "foo bar" > test.txt ``` Or on Windows: ```bash Review Comment: Maybe `bash` should be replaced by `bat`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
