chia7712 commented on code in PR #23524:
URL: https://github.com/apache/kafka/pull/23524#discussion_r4059326836
##########
docs/streams/upgrade-guide.md:
##########
@@ -356,19 +356,19 @@ Stream-DSL users who want to keep the current behavior
can prepend a .filter() o
The `default.dsl.store` config was deprecated in favor of the new
`dsl.store.suppliers.class` config to allow for custom state store
implementations to be configured as the default. If you currently specify
`default.dsl.store=ROCKS_DB` or `default.dsl.store=IN_MEMORY` replace those
configurations with
`dsl.store.suppliers.class=BuiltInDslStoreSuppliers.RocksDBDslStoreSuppliers.class`
and
`dsl.stores.suppliers.class=BuiltInDslStoreSuppliers.InMemoryDslStoreSuppliers.class`
respectively
-A new configuration option `balance_subtopology` for
`rack.aware.assignment.strategy` was introduced in 3.7 release. For more
information, including how it can be enabled and further configured, see the
[**Kafka Streams Developer
Guide**](/43/documentation/streams/developer-guide/config-streams.html#rack-aware-assignment-strategy).
+A new configuration option `balance_subtopology` for
`rack.aware.assignment.strategy` was introduced in 3.7 release. For more
information, including how it can be enabled and further configured, see the
[**Kafka Streams Developer
Guide**](/{version}/documentation/streams/developer-guide/config-streams.html#rack-aware-assignment-strategy).
## Streams API changes in 3.6.0
-Rack aware task assignment was introduced in
[KIP-925](https://cwiki.apache.org/confluence/x/CQ40Dw). Rack aware task
assignment can be enabled for `StickyTaskAssignor` or
`HighAvailabilityTaskAssignor` to compute task assignments which can minimize
cross rack traffic under certain conditions. For more information, including
how it can be enabled and further configured, see the [**Kafka Streams
Developer
Guide**](/43/documentation/streams/developer-guide/config-streams.html#rack-aware-assignment-strategy).
+Rack aware task assignment was introduced in
[KIP-925](https://cwiki.apache.org/confluence/x/CQ40Dw). Rack aware task
assignment can be enabled for `StickyTaskAssignor` or
`HighAvailabilityTaskAssignor` to compute task assignments which can minimize
cross rack traffic under certain conditions. For more information, including
how it can be enabled and further configured, see the [**Kafka Streams
Developer
Guide**](/{version}/documentation/streams/developer-guide/config-streams.html#rack-aware-assignment-strategy).
Review Comment:
>
/{version}/documentation/streams/developer-guide/config-streams.html#rack-aware-assignment-strategy).
Those links are broken. Would you mind fixing them in this PR as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
