chia7712 commented on code in PR #23535: URL: https://github.com/apache/kafka/pull/23535#discussion_r4063251444
########## tests/docker/ducker-ak: ########## @@ -47,7 +47,7 @@ default_num_nodes=14 # The default JDK base image with apt-get support. # The openjdk image has been officially deprecated. For more information, see: https://hub.docker.com/_/openjdk -default_jdk="docker.io/library/eclipse-temurin:17-jdk-jammy" +default_jdk="docker.io/library/eclipse-temurin:25-jdk-noble" Review Comment: I haven't tested it, but I guess JDK 25 may not be able to run quite old Kafka 😃 ########## tests/docker/Dockerfile: ########## @@ -34,11 +35,19 @@ RUN mkdir $KAFKA_BIN_DIR RUN if [ "$KAFKA_MODE" = "native" ]; then \ apt update && apt install -y sudo build-essential libz-dev zlib1g-dev curl jq coreutils libffi-dev cmake pkg-config libfuse-dev && apt-get -y clean ; \ mkdir graalvm ; \ - curl -L "$GRAALVM_URL" -o graalvm.tar.gz ; \ + ARCH=$(uname -m) ; \ + if [ "$ARCH" = "x86_64" ]; then \ + curl -L "$GRAALVM_AMD64_URL" -o graalvm.tar.gz ; \ + elif [ "$ARCH" = "arm64" ] || [ "$ARCH" = "aarch64" ]; then \ + curl -L "$GRAALVM_AARCH64_URL" -o graalvm.tar.gz ; \ + else \ + echo "Unsupported architecture for GraalVM: $ARCH" ; \ + exit 1 ; \ + fi ; \ tar -xzf graalvm.tar.gz -C graalvm --strip-components=1 ; \ mkdir kafka ; \ tar xfz native/kafka.tgz -C kafka --strip-components 1 ; \ - rm graalvm.tar.gz kafka.tgz ; \ + rm graalvm.tar.gz native/kafka.tgz ; \ Review Comment: This is in the intermediate stage, so we could just remove this line :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
