psiby commented on code in PR #23496:
URL: https://github.com/apache/kafka/pull/23496#discussion_r4071082967
##########
connect/api/src/main/java/org/apache/kafka/connect/data/Values.java:
##########
@@ -868,11 +868,15 @@ private SchemaAndValue parseNextToken(boolean embedded,
String token) {
return temporal;
Review Comment:
Good catch — fixed it here with the same guard, so strings like
`2020-01-01:foo` now parses as a string (test added). While checking, I found
arrays/maps had the same issue too (`[1,2]foo` was read as `[1,2]`, dropping
the `foo`), so I guarded those as well. Happy to split any of it into a
separate ticket if you'd prefer, please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
