lucliu1108 commented on code in PR #23516:
URL: https://github.com/apache/kafka/pull/23516#discussion_r4076224257
##########
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##########
@@ -555,13 +555,16 @@ private Map<String, String>
extractPotentialVariables(Map<?, ?> configMap) {
Map<String, ConfigProvider> providers =
instantiateConfigProviders(providerConfigString, configProperties,
classNameFilter);
if (!providers.isEmpty()) {
- ConfigTransformer configTransformer = new
ConfigTransformer(providers);
- ConfigTransformerResult result =
configTransformer.transform(indirectVariables);
- if (!result.data().isEmpty()) {
- resolvedOriginals.putAll(result.data());
+ try {
Review Comment:
Thanks for pointing out!
I added tests for all 3 path
- `testConfigProvidersClosedWhenLaterProviderClassNotFound`: config class
not found
- `testConfigProvidersClosedWhenLaterProviderConfigureThrows`: config() fails
- `testConfigProvidersClosedWhenGetThrows`: `configProviders.get()` fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
