cxm940188 commented on code in PR #23525:
URL: https://github.com/apache/kafka/pull/23525#discussion_r4090376645
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -1637,6 +1652,72 @@ public void testAppendRecordsAtomically() {
appender)).getMessage());
}
+ @ParameterizedTest(name = "numRecords={0}, max={1}")
+ @CsvSource({
+ "1, 1", "1, 2", "2, 2", "3, 2", "4, 2", "5, 2", "6, 2",
+ "2, 1", "3, 1", "5, 1", "100, 1",
+ "1, 10", "2, 10", "10, 3", "100, 7"
Review Comment:
Agreed. Test cases is trimmed to the four scenarios you listed, using
maxRecordsPerBatch of 1 and 10:
- numRecords == maxRecordsPerBatch: (1, 1), (10, 10)
- numRecords is a multiple: (5, 1), (20, 10)
- numRecords > maxRecordsPerBatch but not a multiple: (15, 10)
- numRecords < maxRecordsPerBatch: (5, 10)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
