Parkerhiphop commented on code in PR #23578:
URL: https://github.com/apache/kafka/pull/23578#discussion_r4095239374
##########
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRecords.java:
##########
@@ -54,6 +54,8 @@ public class ConsumerRecords<K, V> implements
Iterable<ConsumerRecord<K, V>> {
static final AtomicLong TAINTED_NEXT_OFFSETS_LAST_LOG_NS = new
AtomicLong(System.nanoTime() - TAINT_LOG_INTERVAL_NS);
/**
+ * @param records The records for each partition. Must not contain empty
lists;
Review Comment:
nit: I think describing the valid input directly makes the constraint a bit
clearer.
How about:
`@param records The records for each partition. Each partition must be
mapped to a non-empty list;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
