[
https://issues.apache.org/jira/browse/KAFKA-21162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-21162:
-----------------------------------
Description:
In [https://github.com/apache/kafka/pull/23566,] we moved most of streams
topology manager logic out of the group coordinator service itself. We should
also move corresponding GroupCoordinatorServiceTest that involves streams group
topology manager as well.
As an idea, we could:
* move the tests that use "internal helpers" such as armBackoff and runOnce
completely from so that we can make the helpers package private
* add unit tests for all public methods in
StreamsGroupTopologyDescriptionManager
* For the plugin-related tests GroupCoordinatorServiceTest, we can decide
whether we want to keep them, or whether they are then just duplicates of the
new unit tests in GroupCoordinatorServiceTest, at which point I'd remove them.
was:
In [https://github.com/apache/kafka/pull/23566,] we moved most of streams
topology manager logic out of the group coordinator service itself. We should
also move corresponding GroupCoordinatorServiceTest that involves streams group
topology manager as well.
As an idea, we could:
* move the tests that use "internal helpers" such as armBackoff and runOnce
completely from so that we can make the helpers package private
* add unit tests for all public methods in
StreamsGroupTopologyDescriptionManager
* For the plugin-related tests GroupCoordinatorServiceTest, we can decide
whether we want to keep them, or whether they are then just duplicates of the
new unit tests in
> Move StreamsGroupTopologyDescriptionManager related tests out of
> GroupCoordinatorService
> ----------------------------------------------------------------------------------------
>
> Key: KAFKA-21162
> URL: https://issues.apache.org/jira/browse/KAFKA-21162
> Project: Kafka
> Issue Type: Test
> Reporter: Lucy Liu
> Assignee: Lucy Liu
> Priority: Major
>
> In [https://github.com/apache/kafka/pull/23566,] we moved most of streams
> topology manager logic out of the group coordinator service itself. We should
> also move corresponding GroupCoordinatorServiceTest that involves streams
> group topology manager as well.
> As an idea, we could:
> * move the tests that use "internal helpers" such as armBackoff and runOnce
> completely from so that we can make the helpers package private
> * add unit tests for all public methods in
> StreamsGroupTopologyDescriptionManager
> * For the plugin-related tests GroupCoordinatorServiceTest, we can decide
> whether we want to keep them, or whether they are then just duplicates of the
> new unit tests in GroupCoordinatorServiceTest, at which point I'd remove them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
