noojung commented on PR #23567: URL: https://github.com/apache/kafka/pull/23567#issuecomment-5830252554
@rahul05ranjan Thanks for the review! The reset is placed after the connector and its tasks have stopped so that they can't record active topics again after the reset. `DistributedHerder` follows the same principle when resetting active topics during revocation. A `finally` block around the entire deletion sequence would also run if an earlier stop or config removal step failed, i.e., even when the connector hasn't been fully stopped and deleted. A narrower `try/finally` around `onDeletion()` would avoid that issue. That said, in standalone mode `onDeletion()` only updates statuses in the in-memory `MemoryStatusBackingStore`, with no external I/O, so I don't expect it to throw during normal operation. Given that, I think keeping the current cleanup sequence and existing exception handling is reasonable for this fix. Please let me know if you'd prefer the narrower `try/finally`; I'd be happy to make that change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
