chia7712 commented on code in PR #23565: URL: https://github.com/apache/kafka/pull/23565#discussion_r4104708455
########## docs/getting-started/upgrade.md: ########## @@ -33,6 +33,7 @@ type: docs ### Notable changes in 4.4.0 * The `ClientQuotaCallback#updateClusterMetadata` method is deprecated and will be removed in Kafka 5.0. Custom implementations of `ClientQuotaCallback` no longer need to override this method, as a default no-op implementation is now provided. For further details, please refer to [KIP-1200](https://cwiki.apache.org/confluence/x/axBJFg). + * Generated protocol message readers now bound collection allocations when decoding messages. Collections with more than 1,000,000 elements and flexible-version tagged-field sections with more than 10,000 fields are rejected before allocation; larger valid collections are no longer preallocated beyond 1,000 elements. This prevents a peer from triggering excessive heap allocation through sender-declared collection sizes. Review Comment: Could those docs reflect recent changes? see https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/protocol/types/CompactArrayOf.java#L87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
