squah-confluent commented on code in PR #23575:
URL: https://github.com/apache/kafka/pull/23575#discussion_r4105394892
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -4627,7 +4625,14 @@ private UpdateTargetAssignmentResult<Map<String,
TasksTuple>> maybeUpdateStreams
group.groupId(), groupEpoch, assignor, assignorTimeMs);
}
- records.addAll(assignmentResult.records());
+ new
TargetAssignmentRecordsBuilder.StreamsTargetAssignmentRecordsBuilder(log,
group.groupId())
+
.withTargetAssignmentMetadata(assignmentResult.targetAssignmentMetadata())
+
.withCurrentMemberIds(updatedMembersAndTargetAssignment.members().keySet())
+
.withPreviousStaticMembers(updatedMembersAndTargetAssignment.staticMembers())
+
.withCurrentStaticMembers(updatedMembersAndTargetAssignment.staticMembers())
Review Comment:
The distinction between previous and current is meant for the async assignor
path. The previous static members are the static members the assignment was
computed off. The current static members are the current state of the group,
which can have changed after the assignment was computed but before it was
applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
