rahul05ranjan commented on PR #23559: URL: https://github.com/apache/kafka/pull/23559#issuecomment-5843298936
Thanks for the thorough review and approval, @rahul05ranjan! On the nit about `ConfigHandler.scala`: I kept it in this PR because it's the runtime side of the same validator/parser mismatch that KAFKA-12986 describes. The validator now rejects leading/internal empty entries and trims each entry, but the runtime parser in `ConfigHandler` was still splitting without trimming, so a value like `"6:102, 7:102"` would pass validation yet fail to parse correctly at runtime. Fixing both together keeps the validator and parser consistent, which is the actual bug being addressed. That said, I'm happy to split it into a separate commit/JIRA if a committer prefers cleaner bisection — just let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
