chia7712 commented on code in PR #23594:
URL: https://github.com/apache/kafka/pull/23594#discussion_r4115825724
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/FineGrainedAutoResetIntegrationTest.java:
##########
@@ -250,7 +252,7 @@ private void shouldOnlyReadForEarliest(
private void commitInvalidOffsets() {
final KafkaConsumer<String, String> consumer = new
KafkaConsumer<>(TestUtils.consumerConfig(
CLUSTER.bootstrapServers(),
- "commit_invalid_offset_app", // Having a separate application id
to avoid waiting for last test poll interval timeout.
+
streamsConfiguration.getProperty(StreamsConfig.APPLICATION_ID_CONFIG),
Review Comment:
This is a bug fix. I think it should commit the invalid offsets to the
specific group instead of an unrelated group.
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/FineGrainedAutoResetIntegrationTest.java:
##########
@@ -165,7 +167,7 @@ public void setUp() throws Exception {
props.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "earliest");
streamsConfiguration = StreamsTestUtils.getStreamsConfig(
- "testAutoOffsetId",
+ safeUniqueTestName(testInfo),
Review Comment:
I prefer to keep the application id in a separate field, which is more
readable, but the current style is fine too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
