[ 
https://issues.apache.org/jira/browse/KAFKA-7245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846416#comment-16846416
 ] 

Matthias J. Sax commented on KAFKA-7245:
----------------------------------------

All public API changes need a KIP. Hence, if we want to remove `put()` we need 
a KIP (even if we will deprecate it first and do the actual remove is a later 
release).

Seems KAFKA-7928 duplicates this ticket. There was not progress on the other 
ticket and not KIP was provided. Hence, I tend to close 7928 as duplicate and 
we can proceed with this ticket as planned. I'll leave comment on 7928 about 
this.

> Deprecate WindowStore#put(key, value)
> -------------------------------------
>
>                 Key: KAFKA-7245
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7245
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Matthias J. Sax
>            Assignee: Omkar Mestry
>            Priority: Minor
>              Labels: needs-kip, newbie
>
> We want to remove `WindowStore#put(key, value)` – for this, we first need to 
> deprecate is via a KIP and remove later.
> Instead of using `WindowStore#put(key, value)` we need to migrate code to 
> specify the timestamp explicitly using `WindowStore#put(key, value, 
> timestamp)`. The current code base use the explicit call to set the timestamp 
> in production code already. The simplified `put(key, value)` is only used in 
> tests, and thus, we would need to update those tests.
> [https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to