chia7712 commented on code in PR #23604:
URL: https://github.com/apache/kafka/pull/23604#discussion_r4122340257
##########
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerTest.java:
##########
@@ -4185,7 +4185,7 @@ public void testRemoteReadFetchDataInfo() throws
RemoteStorageException, IOExcep
when(remoteStorageManager.fetchLogSegment(any(RemoteLogSegmentMetadata.class),
anyInt()))
.thenReturn(fileInputStream);
- RemoteLogManager remoteLogManager = new RemoteLogManager(config,
brokerId, logDir, clusterId, time,
+ try (RemoteLogManager remoteLogManager = new RemoteLogManager(config,
brokerId, logDir, clusterId, time,
Review Comment:
`testFetchOffsetByTimestampWithTieredStorageDoesNotFetchIndexWhenExistsLocally`
and `testDeletionSkippedForSegmentsBeingCopied` also have leak. Would you mind
fixing them in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
