chia7712 commented on code in PR #23570:
URL: https://github.com/apache/kafka/pull/23570#discussion_r4125447435
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##########
@@ -712,6 +712,7 @@ private void close(final boolean clean) {
record = null;
closeTaskSensor.record();
partitionsToResume.clear();
+ consumedOffsets.clear();
Review Comment:
I'm wondering if `consumedOffsets` mixes some logic that should be
decoupled. `consumedOffsets` acts as the checkpoint source in the
source-as-changelog case, and so we need to clean it up. However, we don't need
to do that when `consumedOffsets` only serves as the consumer offsets to commit.
The two roles have different lifecycles, which is how this bug slipped
through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
