harmadasg opened a new pull request, #23637:
URL: https://github.com/apache/kafka/pull/23637

   Follow-up from 
https://github.com/apache/kafka/pull/23609#pullrequestreview-5347245515
   
   The release notes of lz4 
[1.12.0](https://github.com/yawkat/lz4-java/releases/tag/v1.12.0) mentions 
possible breaking changes. What I could found out:
   
   - https://github.com/yawkat/lz4-java/pull/133 and 
https://github.com/yawkat/lz4-java/pull/145 concerns changes with 
LZ4FrameInputStream -> Kafka is not affected as it relies on its own input 
stream implementation 
[Lz4BlockInputStream](https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/compress/Lz4BlockInputStream.java)
   - https://github.com/yawkat/lz4-java/pull/126 input tightening for 
LZ4DecompressorWithLength -> this class is not imported in Kafka
   - Additionally verified update with running 
[Lz4CompressionTest](https://github.com/apache/kafka/blob/trunk/clients/src/test/java/org/apache/kafka/common/compress/Lz4CompressionTest.java),
 all tests passed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to