junrao commented on code in PR #23318: URL: https://github.com/apache/kafka/pull/23318#discussion_r4148985416
########## core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala: ########## @@ -179,22 +179,18 @@ class ReplicaAlterLogDirsThread(name: String, } /** - * Truncate the log for each partition based on current replica's returned epoch and offset. + * Truncate the future replica's log for each partition based on the diverging epoch and offset Review Comment: This comment is not very accurate since truncate() can be called when truncating to the initial fetch offset too, not just from diverging epoch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
