sunm2n commented on PR #23549: URL: https://github.com/apache/kafka/pull/23549#issuecomment-5926253497
@mjsax Could you take a look when you have a chance? You reviewed the recent state updater fixes (KAFKA-20721, KAFKA-20764), and this PR follows up on shutdown cleanup in that area. When the calling thread is interrupted while waiting for task removal, `shutdownStateUpdater()` returns before the updater stops and the remaining tasks are closed. This PR continues cleanup and preserves the interrupt status. CI is green. I'd especially appreciate your view on the design question in the description: should shutdown throw an exception after cleanup if interrupted, or is returning with the interrupt status preserved sufficient? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
