chia7712 commented on code in PR #23245:
URL: https://github.com/apache/kafka/pull/23245#discussion_r4163509106
##########
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##########
@@ -185,7 +198,7 @@ ControllerResult<ApiError> updateFeatures(
int currentClaimedEpoch
) {
List<ApiMessageAndVersion> records =
- BoundedList.newArrayBacked(MAX_RECORDS_PER_USER_OP);
+ BoundedList.newArrayBacked(maxRecordsPerBatch);
Review Comment:
ditto
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -1730,7 +1751,7 @@ public ControllerResult<Void> unregisterBroker(int
brokerId) {
throw new BrokerIdNotRegisteredException("Broker ID " + brokerId +
" is not currently registered");
}
- List<ApiMessageAndVersion> records =
BoundedList.newArrayBacked(MAX_RECORDS_PER_USER_OP);
+ List<ApiMessageAndVersion> records =
BoundedList.newArrayBacked(maxRecordsPerBatch);
Review Comment:
Does it really need the limit? How many items get added depends on the
metadata, which is our single source of truth. If the metadata is wrong, the
server is already broken in a hundred other ways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
