andyhuangdev commented on code in PR #23673:
URL: https://github.com/apache/kafka/pull/23673#discussion_r4164867468
##########
clients/src/test/java/org/apache/kafka/clients/NetworkClientTest.java:
##########
@@ -1271,7 +1296,7 @@ public void testReconnectAfterAddressChange() {
ClientTelemetrySender mockClientTelemetrySender =
mock(ClientTelemetrySender.class);
when(mockClientTelemetrySender.timeToNextUpdate(anyLong())).thenReturn(0L);
- NetworkClient client = new NetworkClient(metadataUpdater, null,
selector, "mock", Uuid.randomUuid(), Integer.MAX_VALUE,
+ NetworkClient client = new NetworkClient(metadataUpdater, null,
selector, "mock", Integer.MAX_VALUE,
Review Comment:
These five constructor calls remove `Uuid.randomUuid()`, but the
`NetworkClient` constructor still requires a `Uuid clientInstanceId` after
`clientId`.
Compilation fails with five `no suitable constructor found for
NetworkClient(...)` errors at lines 1299, 1360, 1413, 1522, and 1640.
Could you restore the UUID arguments and import? Please also retain the
deleted client-instance-ID tests, since that behavior should remain covered by
this refactor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
