chia7712 commented on code in PR #23440:
URL: https://github.com/apache/kafka/pull/23440#discussion_r4172335855
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java:
##########
Review Comment:
I re-read this scenario, and it appears the full test coverage should
include the following cases.
1. the coordinator gets moved
2. the partition leader gets moved
Since they can happen separately or together, there are 3 scenarios we need
to test. The current test shuts down the coordinator's broker, so whether the
partition leader also moves is random.
Also, the only one which needs to run in the background is the consumer,
since it should keep polling during the movement. The others (producer,
shutting down the broker) can run on the main thread.
@AndrewJSchofield @apoorvmittal10 WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
