[
https://issues.apache.org/jira/browse/KAFKA-8371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16847026#comment-16847026
]
ASF GitHub Bot commented on KAFKA-8371:
---------------------------------------
hachikuji commented on pull request #6705: KAFKA-8371: Remove dependence on
ReplicaManager from Partition
URL: https://github.com/apache/kafka/pull/6705
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove ReplicaManager dependence from Partition
> -----------------------------------------------
>
> Key: KAFKA-8371
> URL: https://issues.apache.org/jira/browse/KAFKA-8371
> Project: Kafka
> Issue Type: Improvement
> Reporter: Jason Gustafson
> Assignee: Jason Gustafson
> Priority: Major
> Labels: tech-debt
>
> The dependence on ReplicaManager from the Partition logic makes testing this
> class very cumbersome. Often we are just using ReplicaManager as a way to get
> access to an additional dependency. We should make the actual dependencies
> explicit and we should introduce smaller traits which encapsulate the state
> we actually need.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
