squah-confluent commented on code in PR #23702:
URL: https://github.com/apache/kafka/pull/23702#discussion_r4181477489
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -3880,11 +3880,14 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
new Thread {
override def run : Unit = {
consumer.subscribe(util.Set.of(topic))
+ var started = false
try {
while (consumerThreadRunning.get()) {
consumer.poll(JDuration.ofSeconds(5))
- if (!consumer.assignment.isEmpty && startLatch.getCount > 0L)
+ if (!started && !consumer.assignment.isEmpty) {
Review Comment:
I can see what you mean. At the same time, switching to a rebalance listener
will change the semantics with assignment batching and offloading, since we can
signal readiness before we receive the real assignment.
The only test that looks like it would be impacted is `testDescribeGroups`,
since it asserts on the group epoch after `start()` returns. Let me see if
there's a good way to patch up that test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
