dajac commented on code in PR #23710:
URL: https://github.com/apache/kafka/pull/23710#discussion_r4183688159
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/TopicIds.java:
##########
@@ -122,12 +122,30 @@ public final CoordinatorMetadataImage image() {
@Override
public String name(Uuid id) {
- return topicNames.computeIfAbsent(id, __ ->
image.topicMetadata(id).map(CoordinatorMetadataImage.TopicMetadata::name).orElse(null));
+ // Uses get and put rather than computeIfAbsent, whose lambda
would capture the id and
Review Comment:
Adding the method makes sense. However, I think that we should keep the
cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
