Copilot commented on code in PR #23705:
URL: https://github.com/apache/kafka/pull/23705#discussion_r4195068316
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/StreamsGroupStaticMemberGroupMetadataManagerTest.java:
##########
@@ -1332,8 +1337,9 @@ public void
testStaticMemberLeaveWithLeaveGroupStaticMemberEpochFromUnrevokedSta
}
- @Test
- public void
testStaticMemberLeaveWithLeaveGroupStaticMemberEpochAndRejoinAndOtherRackIdThenGroupBumpOccur()
{
+ @ParameterizedTest
+ @MethodSource("rackIdCases")
+ public void
testStaticMemberLeaveWithLeaveGroupStaticMemberEpochAndRejoinAndOtherRackIdThenGroupBumpOccur(String
newRackId) {
Review Comment:
This parameterized test now also covers rack removal (`newRackId == null`),
but its name only describes switching to another rack ID. Rename it to include
both changed and removed rack IDs so the test's scope is clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
