gabriellefu commented on code in PR #23588:
URL: https://github.com/apache/kafka/pull/23588#discussion_r4199020053
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java:
##########
@@ -563,15 +756,80 @@ public Member(final String processId, final String
memberId) {
private record StandbyCandidate(Member member, boolean isPrevStandby, long
offsetSum) {
}
+ /** Processes with the same values for the keys of {@code
rack.aware.assignment.tags}, see {@link #groupProcessesByTagValues}. */
+ private static final class IdenticalTagGroup {
Review Comment:
make sense, I have moved it to a package-private IdenticalTagGroups<P> next
to RackAwareStandbyPicker. It holds the grouping by tag values and the lazy
least-loaded queue of each group, and takes the assignor's load function and
room check as parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
