jsancio commented on code in PR #23737:
URL: https://github.com/apache/kafka/pull/23737#discussion_r4199092456
##########
clients/src/main/java/org/apache/kafka/common/record/internal/FileRecords.java:
##########
@@ -141,6 +140,25 @@ public void readInto(ByteBuffer buffer, int position)
throws IOException {
buffer.flip();
}
+ /**
+ * Read log batches into the given buffer until there are no bytes
remaining in the buffer or the end of
+ * this FileRecords object is reached.
+ *
+ * @param buffer The buffer to write the batches to
+ * @param position Position to start reading from, relative to the start
of this FileRecords object
+ * @throws IOException If an I/O error occurs, see {@link
FileChannel#read(ByteBuffer, long)} for details on the
+ * possible exceptions
+ * @throws IllegalArgumentException If the position is negative or greater
than the size of this FileRecords object
+ */
+ public void readUntil(ByteBuffer buffer, int position) throws IOException {
Review Comment:
Instead of introducing a new method (readUntil). I would like to understand
if we should fix `readInto` to honor the limit of the FileRecords slice. What
do you think @junrao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]