chia7712 commented on code in PR #23741:
URL: https://github.com/apache/kafka/pull/23741#discussion_r4210405292
##########
build.gradle:
##########
@@ -1245,6 +1245,9 @@ project(':core') {
testRuntimeOnly.exclude module: 'api-ldap-schema-data'
testCompileClasspath.exclude group: 'org.bouncycastle', module:
'bcprov-jdk15on'
testRuntimeClasspath.exclude group: 'org.bouncycastle', module:
'bcprov-jdk15on'
+ // JUnit 4 is a transitive runtime dependency of mock-oauth2-server (via
okhttp3 mockwebserver),
+ // keep it off the compile classpath so tests can't accidentally use
JUnit 4 APIs.
+ testCompileClasspath.exclude group: 'junit', module: 'junit'
Review Comment:
It seems mock-oauth2-server is only used by ClientOAuthIntegrationTest. As a
follow-up, maybe we can refactor the client_credentials and client assertion
cases to use Keycloak like ClientAssertionKeycloakIntegrationTest does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
