sunm2n opened a new pull request, #23746:
URL: https://github.com/apache/kafka/pull/23746

   SaslAuthenticatorTest#testServerLoginCallbackOverride puts a
   listener-prefixed sasl.login.callback.handler.class to check that it is
   rejected without a mechanism prefix, but then removes the "plain."-prefixed
   key instead. That key had already been removed by the previous step, so
   the listener-prefixed key stays in the config for the rest of the test.
   
   This does not change what the test verifies. After the listener prefix is
   stripped, the server looks up the handler only with the mechanism prefix,
   so the leftover key is ignored and the final step still checks the
   listener and mechanism prefixed override.
   
   This removes the listener-prefixed key instead, and replaces the three
   try/fail/catch blocks in the test with assertThrows, keeping the expected
   exception type and the failure messages.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to