lucasbru opened a new pull request, #23747:
URL: https://github.com/apache/kafka/pull/23747

   Converting an empty streams group to a classic group requires the broker to 
delete the group's stored topology description from the plugin first. This path 
was only unit-tested against mocks; no test sent a real classic 
JoinGroupRequest to a running broker, and the failed-join and periodic-cleanup 
halves were never chained together.
   
   This adds three single-broker integration tests to 
StreamsGroupTopologyDescriptionRequestTest. The first joins a classic member to 
an empty streams group with a stored topology and checks that the broker calls 
plugin.deleteTopology and converts the group. The second makes deleteTopology 
fail and checks that the join is rejected with the retriable 
REBALANCE_IN_PROGRESS while the group stays a streams group. The third chains 
the failure with the periodic cleanup cycle: after the plugin recovers, the 
cycle clears the stored topology without any client involvement, and a later 
classic join converts the group.
   
   FailingTopologyDescriptionPlugin gains a per-group counter of deleteTopology 
invocations, so the tests can assert that the broker actually reached the 
plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to