squah-confluent commented on code in PR #23688:
URL: https://github.com/apache/kafka/pull/23688#discussion_r4240161341
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1389,6 +1397,7 @@ private void convertToClassicGroup(
// Directly update the states instead of replaying the records because
// the classicGroup reference is needed for triggering the rebalance.
+ cancelTargetAssignmentUpdate(consumerGroup.groupId());
Review Comment:
Hm, it's very tempting to move it there, but I think it runs counter to the
current coordinator design? We don't start or cancel timers or tasks in the
replay path and `removeGroup` is part of the replay path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
