see-quick opened a new pull request, #23771:
URL: https://github.com/apache/kafka/pull/23771

   The jvm image can only be built from 4.x archives today. With a 3.x archive, 
`jsa_launch` formats `config/server.properties`, which in 3.x is the ZooKeeper 
config, so `kafka-storage.sh format` refuses it and the build fails. The final 
stage would then also fail on copying `config/log4j2.yaml`, which 3.x does not 
ship (log4j2 arrived in 4.0, KAFKA-9366).
   
   Both scripts now check for `config/kraft/server.properties`, which exists in 
every 3.x archive and was removed in 4.0 (KAFKA-18229): 
   - `jsa_launch` uses that config, without `--standalone` (3.7 and 3.8
     have no `format --standalone`)
   - the Dockerfile copies the log4j 1 configs instead of the log4j2 ones
   
   > [!IMPORTANT] 
   > Behaviour for 4.x archives is unchanged.
   
   This makes it possible to build images of older releases with trunks 
`docker/`, e.g. for cross-version testing.
   
   Checked with podman on the default base: 3.7.2, 3.9.2 and 4.3.1 archives 
build, and each broker starts and serves a topic. The sanity suite passes on 
the 3.9.2 image (2/2) when run with 4.3.1 tools (`-t -a kafka_2.13-4.3.1.tgz`). 
With 3.9.2's own tools it fails, because the tests use trunk CLI options 
(`--reader-property`, `--formatter-property`) that 3.x does not know.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to